github/drone
5
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-09 06:51:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: [code-791]: fixed deleted lines issue (#377)

Browse Source
This commit is contained in:
Calvin Lee 2023-08-30 16:39:55 +00:00 committed by Harness
parent 332c8d0a27
commit ec20dec12c
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/components/Changes/Changes.tsx
View File

@ -244,7 +244,7 @@ export const Changes: React.FC<ChangesProps> = ({
vars={{ vars={{
changedFilesLink: <ChangesDropdown diffs={diffs} />, changedFilesLink: <ChangesDropdown diffs={diffs} />,
addedLines: formatNumber(diffStats.addedLines), addedLines: formatNumber(diffStats.addedLines),
deletedLines: formatNumber(diffStats.deletedLines), deletedLines: diffStats.deletedLines ? formatNumber(diffStats.deletedLines) : '0',
configuration: ( configuration: (
<DiffViewConfiguration <DiffViewConfiguration
viewStyle={viewStyle} viewStyle={viewStyle}

3
web/src/components/Changes/CommitRangeDropdown/CommitRangeDropdown.tsx
View File

@ -50,7 +50,6 @@ const CommitRangeDropdown: React.FC<CommitRangeDropdownProps> = ({
setSelectedCommits setSelectedCommits
}) => { }) => {
const { getString } = useStrings() const { getString } = useStrings()
const allCommitsSHA = allCommits.map(commit => commit.sha as string) const allCommitsSHA = allCommits.map(commit => commit.sha as string)
useEffect(() => { useEffect(() => {
@ -63,7 +62,7 @@ const CommitRangeDropdown: React.FC<CommitRangeDropdownProps> = ({
event: React.MouseEvent<HTMLInputElement | HTMLDivElement, MouseEvent>, event: React.MouseEvent<HTMLInputElement | HTMLDivElement, MouseEvent>,
selectedCommitSHA: string selectedCommitSHA: string
) => { ) => {
if (event.shiftKey || selectedCommits.length > 1) { if (event.shiftKey) {
// Select Commit // Select Commit
setSelectedCommits(current => { setSelectedCommits(current => {
if (current.includes(selectedCommitSHA)) { if (current.includes(selectedCommitSHA)) {