From eb6af94cbda837be5ecbb379a57b8594be7147bc Mon Sep 17 00:00:00 2001 From: Tudor Macari Date: Wed, 20 Nov 2024 13:27:40 +0000 Subject: [PATCH] feat: [AH-690]: log errors (#3026) * feat: [AH-690]: log errors * fix: [AH-597]: fix layers api for application/vnd.oci.image.manifest.v1+json manifests --- .../api/controller/metadata/get_artifacts_docker_layers.go | 2 +- registry/app/pkg/docker/helpers.go | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/registry/app/api/controller/metadata/get_artifacts_docker_layers.go b/registry/app/api/controller/metadata/get_artifacts_docker_layers.go index 459d40174..7e4ce7ca2 100644 --- a/registry/app/api/controller/metadata/get_artifacts_docker_layers.go +++ b/registry/app/api/controller/metadata/get_artifacts_docker_layers.go @@ -171,7 +171,7 @@ func getManifestLayers( return deserializedManifest.Layers(), nil case *ocischema.DeserializedManifest: deserializedManifest := &ocischema.DeserializedManifest{} - mediaType, bytes, _ := deserializedManifest.Payload() + mediaType, bytes, _ := manifest.Payload() err := deserializedManifest.UnmarshalJSON(bytes) if err != nil { return nil, fmt.Errorf("failed to unmarshal %s manifest: %w", mediaType, err) diff --git a/registry/app/pkg/docker/helpers.go b/registry/app/pkg/docker/helpers.go index 3614c9fc7..5847173fd 100644 --- a/registry/app/pkg/docker/helpers.go +++ b/registry/app/pkg/docker/helpers.go @@ -25,6 +25,8 @@ import ( "github.com/harness/gitness/registry/app/store" "github.com/harness/gitness/types" "github.com/harness/gitness/types/enum" + + "github.com/rs/zerolog/log" ) // GetRegistryCheckAccess fetches an active registry @@ -62,7 +64,9 @@ func GetRegistryCheckAccess( } if err = apiauth.CheckRegistry(ctx, authorizer, session, permissionChecks...); err != nil { - return fmt.Errorf("access check failed: %w", err) + err = fmt.Errorf("registgry access check failed: %w", err) + log.Ctx(ctx).Error().Msgf("Error: %v", err) + return err } return nil