github/drone
5
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-19 02:20:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

default list of PR states should be empty (#210)

Browse Source
This commit is contained in:
Marko Gaćeša 2023-01-14 03:47:42 +01:00 committed by GitHub
parent bbae67299c
commit e5dc9754cd
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/api/controller/pullreq/merge.go
View File

@ -29,7 +29,7 @@ type MergeInput struct {
// Merge merges the pull request. // Merge merges the pull request.
// //
//nolint:gocognit,funlen // no need to refactor //nolint:gocognit // no need to refactor
func (c *Controller) Merge( func (c *Controller) Merge(
ctx context.Context, ctx context.Context,
session *auth.Session, session *auth.Session,

8
internal/api/request/pullreq.go
View File

@ -35,16 +35,14 @@ func parsePullReqStates(r *http.Request) []enum.PullReqState {
strStates := r.Form[QueryParamState] strStates := r.Form[QueryParamState]
m := make(map[enum.PullReqState]struct{}) // use map to eliminate duplicates m := make(map[enum.PullReqState]struct{}) // use map to eliminate duplicates
for _, s := range strStates { for _, s := range strStates {
if s == "" {
continue
}
if state, ok := enum.PullReqState(s).Sanitize(); ok { if state, ok := enum.PullReqState(s).Sanitize(); ok {
m[state] = struct{}{} m[state] = struct{}{}
} }
} }
if len(m) == 0 {
all, _ := enum.GetAllPullReqStates()
return all // the default is all PRs
}
states := make([]enum.PullReqState, 0, len(m)) states := make([]enum.PullReqState, 0, len(m))
for s := range m { for s := range m {
states = append(states, s) states = append(states, s)