github/drone
5
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-13 23:50:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: [CDE-468]: Added a check to differentiate between CDE Gitspace and Gitness (#2955)

Browse Source 
* Re-trigger Build
* Bug Fix
This commit is contained in:
Neel Khamar 2024-11-08 09:05:44 +00:00 committed by Harness
parent 2f54f4003a
commit e3f56f5a3d
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/cde-gitness/pages/GitspaceCreate/CDECreateGitspace.tsx
View File

@ -151,7 +151,7 @@ export const CDECreateGitspace = () => {
...includeQueryParams, ...includeQueryParams,
metadata: { infraProvider: 'HARNESS_GCP' } metadata: { infraProvider: 'HARNESS_GCP' }
}} }}
validationSchema={validateGitnessForm(getString)} validationSchema={validateGitnessForm(getString, true)}
formName="importRepoForm" formName="importRepoForm"
enableReinitialize> enableReinitialize>
{formik => { {formik => {

4
web/src/cde-gitness/pages/GitspaceCreate/GitspaceCreate.utils.ts
View File

@ -18,7 +18,7 @@ import * as yup from 'yup'
import type { UseStringsReturn } from 'framework/strings' import type { UseStringsReturn } from 'framework/strings'
import { IDEType } from 'cde-gitness/constants' import { IDEType } from 'cde-gitness/constants'
export const validateGitnessForm = (getString: UseStringsReturn['getString']) => export const validateGitnessForm = (getString: UseStringsReturn['getString'], isCDE = false) =>
yup.object().shape({ yup.object().shape({
branch: yup.string().trim().required(getString('cde.branchValidationMessage')), branch: yup.string().trim().required(getString('cde.branchValidationMessage')),
code_repo_url: yup.string().trim().required(getString('cde.repoValidationMessage')), code_repo_url: yup.string().trim().required(getString('cde.repoValidationMessage')),
@ -27,7 +27,7 @@ export const validateGitnessForm = (getString: UseStringsReturn['getString']) =>
resource_identifier: yup.string().trim().required(getString('cde.machineValidationMessage')), resource_identifier: yup.string().trim().required(getString('cde.machineValidationMessage')),
name: yup.string().trim().required(), name: yup.string().trim().required(),
ssh_token_identifier: yup.string().when('ide', { ssh_token_identifier: yup.string().when('ide', {
is: IDEType.VSCODE, is: ide => ide === IDEType.VSCODE && isCDE,
then: yup.string().required(getString('cde.sshValidationMessage')) then: yup.string().required(getString('cde.sshValidationMessage'))
}) })
}) })