From dc15e6bb1861aa793cf6a085f66832e579e9f1e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=9Ctan-nhu=E2=80=9D?= <“tan@harness.io”> Date: Tue, 25 Apr 2023 17:46:40 -0700 Subject: [PATCH] feat: [CODE-215]: Move GitBlame to a separate tab + UI tweaks per Design --- .../CommitModalButton/CommitModalButton.tsx | 50 +++- .../components/LatestCommit/LatestCommit.tsx | 30 +- .../OptionsMenuButton.module.scss | 8 + .../OptionsMenuButton/OptionsMenuButton.tsx | 19 +- .../PlainButton/PlainButton.module.scss | 17 ++ .../PlainButton/PlainButton.module.scss.d.ts | 7 + .../components/PlainButton/PlainButton.tsx | 5 + .../RepositoryPageHeader.tsx | 2 +- web/src/framework/strings/stringTypes.ts | 3 + web/src/i18n/strings.en.yaml | 7 +- .../pages/PullRequest/PullRequest.module.scss | 1 - web/src/pages/PullRequest/PullRequest.tsx | 1 - .../ContentHeader/ContentHeader.module.scss | 5 +- .../FileContent/FileContent.module.scss | 60 ++++ .../FileContent/FileContent.module.scss.d.ts | 5 + .../FileContent/FileContent.tsx | 266 +++++++++++------- .../FileContent/GitBlame.module.scss | 10 +- .../FileContent/GitBlame.tsx | 1 + .../FolderContent/FolderContent.module.scss | 2 + .../FolderContent/Readme.tsx | 17 +- .../RepositoryContent.module.scss | 4 +- .../RepositoryContent/RepositoryContent.tsx | 2 +- web/src/utils/Utils.ts | 11 +- 23 files changed, 375 insertions(+), 158 deletions(-) create mode 100644 web/src/components/PlainButton/PlainButton.module.scss create mode 100644 web/src/components/PlainButton/PlainButton.module.scss.d.ts create mode 100644 web/src/components/PlainButton/PlainButton.tsx diff --git a/web/src/components/CommitModalButton/CommitModalButton.tsx b/web/src/components/CommitModalButton/CommitModalButton.tsx index b7cf8cbd8..fdf39a313 100644 --- a/web/src/components/CommitModalButton/CommitModalButton.tsx +++ b/web/src/components/CommitModalButton/CommitModalButton.tsx @@ -45,7 +45,7 @@ interface FormData { newBranch?: string } -interface CommitModalButtonProps extends Omit, Pick { +interface CommitModalProps extends Pick { commitAction: GitCommitAction gitRef: string resourcePath: string @@ -57,7 +57,7 @@ interface CommitModalButtonProps extends Omit void } -export const CommitModalButton: React.FC = ({ +export function useCommitModal({ repoMetadata, commitAction, gitRef, @@ -67,9 +67,8 @@ export const CommitModalButton: React.FC = ({ disableBranchCreation = false, payload = '', sha, - onSuccess, - ...props -}) => { + onSuccess +}: CommitModalProps) { const ModalComponent: React.FC = () => { const { getString } = useStrings() const [targetBranchOption, setTargetBranchOption] = useState(CommitToGitRefOption.DIRECTLY) @@ -229,5 +228,46 @@ export const CommitModalButton: React.FC = ({ const [openModal, hideModal] = useModalHook(ModalComponent, [onSuccess, gitRef, resourcePath, commitTitlePlaceHolder]) + return [openModal, hideModal] +} + +interface CommitModalButtonProps extends Omit, Pick { + commitAction: GitCommitAction + gitRef: string + resourcePath: string + commitTitlePlaceHolder: string + disableBranchCreation?: boolean + oldResourcePath?: string + payload?: string + sha?: string + onSuccess: (data: RepoCommitFilesResponse, newBranch?: string) => void +} + +export const CommitModalButton: React.FC = ({ + repoMetadata, + commitAction, + gitRef, + resourcePath, + commitTitlePlaceHolder, + oldResourcePath, + disableBranchCreation = false, + payload = '', + sha, + onSuccess, + ...props +}) => { + const [openModal] = useCommitModal({ + repoMetadata, + commitAction, + gitRef, + resourcePath, + commitTitlePlaceHolder, + oldResourcePath, + disableBranchCreation, + payload, + sha, + onSuccess + }) + return