github/drone
5
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-17 09:30:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: [code-1268]: add hover on code approval (#952)

Browse Source
This commit is contained in:
Calvin Lee 2024-01-08 21:05:07 +00:00 committed by Harness
parent a085839d84
commit cb0cee8721
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
web/src/pages/PullRequest/CodeOwners/CodeOwnersOverview.tsx
View File

@ -289,21 +289,22 @@ const CodeOwnerSection: React.FC<CodeOwnerSectionsProps> = ({ data }) => {
) )
return ( return (
<Layout.Horizontal className={css.ownerContainer} spacing="tiny"> <Layout.Horizontal className={css.ownerContainer} spacing="tiny">
{approvedEvaluations?.map((owner, idx) => { {approvedEvaluations?.map(({ owner }, idx) => {
if (idx < 4) { if (idx < 4) {
return ( return (
<Avatar <Avatar
key={`approved-${owner.owner?.display_name}-avatar`} key={`approved-${owner?.display_name}-avatar`}
hoverCard={false} hoverCard={true}
email={owner?.email || ' '}
size="small" size="small"
name={owner.owner?.display_name || ''} name={owner?.display_name || ''}
/> />
) )
} }
if (idx === 4 && approvedEvaluations.length && approvedEvaluations.length > 4) { if (idx === 4 && approvedEvaluations.length && approvedEvaluations.length > 4) {
return ( return (
<Text <Text
key={`approved-${owner.owner?.display_name}-text`} key={`approved-${owner?.display_name}-text`}
padding={{ top: 'xsmall' }} padding={{ top: 'xsmall' }}
tooltipProps={{ isDark: true }} tooltipProps={{ isDark: true }}
tooltip={ tooltip={