github/drone
5
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-07 05:10:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix resolution of relative avatar urls for Gogs published in subpath

Browse Source 
Closes #1701
Includes a new test, and updates expected results for 3 of them (adding
the schema part)
This commit is contained in:
Sandro Santilli 2016-07-06 15:58:31 +02:00
parent 2d7c7bd860
commit cacfd0c444
2 changed files with 23 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
remote/gogs/helper.go
View File

@ -120,15 +120,23 @@ func fixMalformedAvatar(url string) string {
} }
// expandAvatar is a helper function that converts a relative avatar URL to the // expandAvatar is a helper function that converts a relative avatar URL to the
// abosolute url. // absolute url.
func expandAvatar(repo, rawurl string) string { func expandAvatar(repo, rawurl string) string {
if !strings.HasPrefix(rawurl, "/avatars/") { aurl, err := url.Parse(rawurl)
return rawurl
}
url, err := url.Parse(repo)
if err != nil { if err != nil {
return rawurl return rawurl
} }
url.Path = rawurl if aurl.IsAbs() {
return url.String() // Url is already absolute
return aurl.String()
}
// Resolve to base
burl, err := url.Parse(repo)
if err != nil {
return rawurl
}
aurl = burl.ResolveReference(aurl)
return aurl.String()
} }

12
remote/gogs/helper_test.go
View File

@ -47,7 +47,7 @@ func Test_parse(t *testing.T) {
g.Assert(build.Link).Equal(hook.Compare) g.Assert(build.Link).Equal(hook.Compare)
g.Assert(build.Branch).Equal("master") g.Assert(build.Branch).Equal("master")
g.Assert(build.Message).Equal(hook.Commits[0].Message) g.Assert(build.Message).Equal(hook.Commits[0].Message)
g.Assert(build.Avatar).Equal("//1.gravatar.com/avatar/8c58a0be77ee441bb8f8595b7f1b4e87") g.Assert(build.Avatar).Equal("http://1.gravatar.com/avatar/8c58a0be77ee441bb8f8595b7f1b4e87")
g.Assert(build.Author).Equal(hook.Sender.Login) g.Assert(build.Author).Equal(hook.Sender.Login)
}) })
@ -92,7 +92,7 @@ func Test_parse(t *testing.T) {
FullName: "gophers/hello-world", FullName: "gophers/hello-world",
Owner: gogs.User{ Owner: gogs.User{
UserName: "gordon", UserName: "gordon",
AvatarUrl: "//1.gravatar.com/avatar/8c58a0be77ee441bb8f8595b7f1b4e87", AvatarUrl: "http://1.gravatar.com/avatar/8c58a0be77ee441bb8f8595b7f1b4e87",
}, },
CloneUrl: "http://gogs.golang.org/gophers/hello-world.git", CloneUrl: "http://gogs.golang.org/gophers/hello-world.git",
HtmlUrl: "http://gogs.golang.org/gophers/hello-world", HtmlUrl: "http://gogs.golang.org/gophers/hello-world",
@ -114,7 +114,7 @@ func Test_parse(t *testing.T) {
FullName: "gophers/hello-world", FullName: "gophers/hello-world",
Owner: gogs.User{ Owner: gogs.User{
UserName: "gordon", UserName: "gordon",
AvatarUrl: "//1.gravatar.com/avatar/8c58a0be77ee441bb8f8595b7f1b4e87", AvatarUrl: "http://1.gravatar.com/avatar/8c58a0be77ee441bb8f8595b7f1b4e87",
}, },
} }
repo := toRepoLite(&from) repo := toRepoLite(&from)
@ -165,7 +165,11 @@ func Test_parse(t *testing.T) {
}, },
{ {
"//1.gravatar.com/avatar/8c58a0be77ee441bb8f8595b7f1b4e87", "//1.gravatar.com/avatar/8c58a0be77ee441bb8f8595b7f1b4e87",
"//1.gravatar.com/avatar/8c58a0be77ee441bb8f8595b7f1b4e87", "http://1.gravatar.com/avatar/8c58a0be77ee441bb8f8595b7f1b4e87",
},
{
"/gogs/avatars/2",
"http://gogs.io/gogs/avatars/2",
}, },
} }