From c7714aafea88edb22af6c5f5666e9dcb7aa2e789 Mon Sep 17 00:00:00 2001
From: Vardan Bansal <vardan.bansal@harness.io>
Date: Tue, 12 Sep 2023 12:15:41 -0700
Subject: [PATCH] fix eslint errors

---
 .../NewPipelineModal/NewPipelineModal.tsx     |  2 +-
 .../components/PluginsPanel/PluginsPanel.tsx  | 23 ++++++++++---------
 .../RunPipelineModal/RunPipelineModal.tsx     |  6 ++---
 .../AddUpdatePipeline/AddUpdatePipeline.tsx   |  6 +++--
 4 files changed, 20 insertions(+), 17 deletions(-)

diff --git a/web/src/components/NewPipelineModal/NewPipelineModal.tsx b/web/src/components/NewPipelineModal/NewPipelineModal.tsx
index 5bfb5807b..99685a42b 100644
--- a/web/src/components/NewPipelineModal/NewPipelineModal.tsx
+++ b/web/src/components/NewPipelineModal/NewPipelineModal.tsx
@@ -2,7 +2,7 @@ import React, { useMemo, useState } from 'react'
 import { useHistory } from 'react-router-dom'
 import { useMutate } from 'restful-react'
 import * as yup from 'yup'
-import { capitalize } from 'lodash'
+import { capitalize } from 'lodash-es'
 import {
   Button,
   ButtonVariation,
diff --git a/web/src/components/PluginsPanel/PluginsPanel.tsx b/web/src/components/PluginsPanel/PluginsPanel.tsx
index 29e16c50c..82002b53a 100644
--- a/web/src/components/PluginsPanel/PluginsPanel.tsx
+++ b/web/src/components/PluginsPanel/PluginsPanel.tsx
@@ -2,10 +2,10 @@ import React, { useCallback, useEffect, useState } from 'react'
 import { Formik } from 'formik'
 import { capitalize, get } from 'lodash-es'
 import { useGet } from 'restful-react'
-import { useStrings } from 'framework/strings'
-import { Button, ButtonVariation, Container, FormInput, FormikForm, Layout, Tab, Tabs, Text } from '@harnessio/uicore'
 import { Color, FontVariation } from '@harnessio/design-system'
 import { Icon, type IconName } from '@harnessio/icons'
+import { Button, ButtonVariation, Container, FormInput, FormikForm, Layout, Tab, Tabs, Text } from '@harnessio/uicore'
+import { useStrings } from 'framework/strings'
 import { LIST_FETCHING_LIMIT } from 'utils/Utils'
 import type { TypesPlugin } from 'services/code'
 import { YamlVersion } from 'pages/AddUpdatePipeline/Constants'
@@ -104,19 +104,19 @@ export const PluginsPanel = ({ version = YamlVersion.V0, onPluginAddUpdate }: Pl
     return (
       <>
         {PluginCategories.map((item: PluginInterface) => {
-          const { name, category, description, icon } = item
+          const { name, category: pluginCategory, description, icon } = item
           return (
             <Layout.Horizontal
               onClick={() => {
-                setCategory(category)
-                if (category === PluginCategory.Drone) {
+                setCategory(pluginCategory)
+                if (pluginCategory === PluginCategory.Drone) {
                   setPanelView(PluginPanelView.Listing)
-                } else if (category === PluginCategory.Harness) {
+                } else if (pluginCategory === PluginCategory.Harness) {
                   setPlugin({ uid: getString('run') })
                   setPanelView(PluginPanelView.Configuration)
                 }
               }}
-              key={category}
+              key={pluginCategory}
               padding={{ left: 'medium', right: 'medium', top: 'medium', bottom: 'medium' }}
               flex={{ justifyContent: 'flex-start' }}
               className={css.plugin}>
@@ -160,8 +160,8 @@ export const PluginsPanel = ({ version = YamlVersion.V0, onPluginAddUpdate }: Pl
           </Text>
         </Layout.Horizontal>
         <Container>
-          {plugins?.map((plugin: TypesPlugin) => {
-            const { uid, description } = plugin
+          {plugins?.map((_plugin: TypesPlugin) => {
+            const { uid, description } = _plugin
             return (
               <Layout.Horizontal
                 flex={{ justifyContent: 'flex-start' }}
@@ -169,8 +169,9 @@ export const PluginsPanel = ({ version = YamlVersion.V0, onPluginAddUpdate }: Pl
                 className={css.plugin}
                 onClick={() => {
                   setPanelView(PluginPanelView.Configuration)
-                  setPlugin(plugin)
-                }}>
+                  setPlugin(_plugin)
+                }}
+                key={uid}>
                 <Icon name={'gear'} size={25} />
                 <Layout.Vertical padding={{ left: 'small' }}>
                   <Text font={{ variation: FontVariation.BODY2 }} color={Color.PRIMARY_7}>
diff --git a/web/src/components/RunPipelineModal/RunPipelineModal.tsx b/web/src/components/RunPipelineModal/RunPipelineModal.tsx
index 3ad1c9768..9dccc9155 100644
--- a/web/src/components/RunPipelineModal/RunPipelineModal.tsx
+++ b/web/src/components/RunPipelineModal/RunPipelineModal.tsx
@@ -2,7 +2,7 @@ import React, { useMemo, useState } from 'react'
 import { useHistory } from 'react-router'
 import { useMutate } from 'restful-react'
 import * as yup from 'yup'
-import { capitalize } from 'lodash'
+import { capitalize } from 'lodash-es'
 import { FontVariation } from '@harnessio/design-system'
 import {
   Button,
@@ -118,9 +118,9 @@ const useRunPipelineModal = () => {
   }, [repo?.default_branch, pipeline])
 
   return {
-    openModal: ({ repoMetadata, pipeline }: { repoMetadata: TypesRepository; pipeline: string }) => {
+    openModal: ({ repoMetadata, pipeline: pipelineUid }: { repoMetadata: TypesRepository; pipeline: string }) => {
       setRepo(repoMetadata)
-      setPipeline(pipeline)
+      setPipeline(pipelineUid)
       openModal()
     },
     hideModal
diff --git a/web/src/pages/AddUpdatePipeline/AddUpdatePipeline.tsx b/web/src/pages/AddUpdatePipeline/AddUpdatePipeline.tsx
index 29d5b23b2..149d15418 100644
--- a/web/src/pages/AddUpdatePipeline/AddUpdatePipeline.tsx
+++ b/web/src/pages/AddUpdatePipeline/AddUpdatePipeline.tsx
@@ -1,7 +1,7 @@
 import React, { useCallback, useEffect, useMemo, useState } from 'react'
 import { useGet, useMutate } from 'restful-react'
 import { Link, useParams } from 'react-router-dom'
-import { get, isEmpty, isUndefined, set } from 'lodash'
+import { get, isEmpty, isUndefined, set } from 'lodash-es'
 import { stringify } from 'yaml'
 import { Menu, PopoverPosition } from '@blueprintjs/core'
 import {
@@ -222,7 +222,9 @@ const AddUpdatePipeline = (): JSX.Element => {
       const updatedPipelineAsObj = updatePipeline(pluginFormData)
       setPipelineAsObj(updatedPipelineAsObj)
       setPipelineAsYaml(stringify(updatedPipelineAsObj))
-    } catch (ex) {}
+    } catch (ex) {
+      // ignore exception
+    }
   }
 
   const renderCTA = useCallback(() => {