github/drone
5
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-11 14:40:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

small ui fixes in pipelines (#487)

Browse Source
This commit is contained in:
Dan Wilson 2023-09-14 13:26:33 +00:00 committed by Harness
parent 67883e90e0
commit ae89113aa9
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/pages/Execution/Execution.tsx
View File

@ -47,7 +47,7 @@ const Execution = () => {
useSpaceSSE({ useSpaceSSE({
space, space,
events: ['execution_updated', 'execution_completed'], events: ['execution_updated', 'execution_completed', 'execution_canceled', 'execution_running'],
onEvent: data => { onEvent: data => {
if ( if (
data?.repo_id === execution?.repo_id && data?.repo_id === execution?.repo_id &&

2
web/src/pages/ExecutionList/ExecutionList.tsx
View File

@ -69,7 +69,7 @@ const ExecutionList = () => {
useSpaceSSE({ useSpaceSSE({
space, space,
events: ['execution_updated', 'execution_completed'], events: ['execution_updated', 'execution_completed', 'execution_canceled', 'execution_running'],
onEvent: data => { onEvent: data => {
// ideally this would include number - so we only check for executions on the page - but what if new executions are kicked off? - could check for ids that are higher than the lowest id on the page? // ideally this would include number - so we only check for executions on the page - but what if new executions are kicked off? - could check for ids that are higher than the lowest id on the page?
if ( if (

6
web/src/pages/PipelineList/PipelineList.tsx
View File

@ -79,7 +79,7 @@ const PipelineList = () => {
useSpaceSSE({ useSpaceSSE({
space, space,
events: ['execution_updated', 'execution_completed'], events: ['execution_updated', 'execution_completed', 'execution_canceled', 'execution_running'],
onEvent: data => { onEvent: data => {
// should I include pipeline id here? what if a new pipeline is created? coould check for ids that are higher than the lowest id on the page? // should I include pipeline id here? what if a new pipeline is created? coould check for ids that are higher than the lowest id on the page?
if (pipelines?.some(pipeline => pipeline.repo_id === data?.repo_id && pipeline.id === data?.pipeline_id)) { if (pipelines?.some(pipeline => pipeline.repo_id === data?.repo_id && pipeline.id === data?.pipeline_id)) {
@ -105,7 +105,7 @@ const PipelineList = () => {
() => [ () => [
{ {
Header: getString('pipelines.name'), Header: getString('pipelines.name'),
width: 'calc(100% - 210px)', width: 'calc(50% - 105px)',
Cell: ({ row }: CellProps<TypesPipeline>) => { Cell: ({ row }: CellProps<TypesPipeline>) => {
const record = row.original const record = row.original
return ( return (
@ -127,7 +127,7 @@ const PipelineList = () => {
}, },
{ {
Header: getString('pipelines.lastExecution'), Header: getString('pipelines.lastExecution'),
width: 'calc(50% - 90px)', width: 'calc(50% - 105px)',
Cell: ({ row }: CellProps<TypesPipeline>) => { Cell: ({ row }: CellProps<TypesPipeline>) => {
const record = row.original.execution const record = row.original.execution