github/drone
5
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-04 14:12:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: [CODE-2501] Return 200 with an empty list for commits on non-existing references (#3366)

Browse Source
This commit is contained in:
Atefeh Mohseni Ejiyeh 2025-02-01 02:28:29 +00:00 committed by Harness
parent 92e39dee79
commit a75e6ec4ec
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
git/api/commit.go
View File

@ -189,14 +189,10 @@ func (g *Git) listCommitSHAs(
output := &bytes.Buffer{} output := &bytes.Buffer{}
err := cmd.Run(ctx, command.WithDir(repoPath), command.WithStdout(output)) err := cmd.Run(ctx, command.WithDir(repoPath), command.WithStdout(output))
if cErr := command.AsError(err); cErr != nil && cErr.IsExitCode(128) { if cErr := command.AsError(err); cErr != nil && cErr.IsExitCode(128) {
if cErr.IsAmbiguousArgErr() { if cErr.IsAmbiguousArgErr() || cErr.IsBadObject() {
return nil, errors.NotFound("reference %q is ambiguous", ref) return []string{}, nil // return an empty list if reference doesn't exist
}
if cErr.IsBadObject() {
return nil, errors.NotFound("commit not found")
} }
} }
if err != nil { if err != nil {
return nil, processGitErrorf(err, "failed to trigger rev-list command") return nil, processGitErrorf(err, "failed to trigger rev-list command")
} }