github/drone
5
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-03 22:13:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: [CDE-195]: missing repo type is treated as unknown for gitspaces (#2317)

Browse Source 
* feat: [CDE-195]: missing repo type is treated as unknown for gitspaces
This commit is contained in:
Ansuman Satapathy 2024-07-30 08:14:49 +00:00 committed by Harness
parent 42af216dc7
commit a3203ef284
2 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/gitspace/scm/public_scm.go
View File

@ -104,14 +104,15 @@ func (s GenericSCM) ResolveCredentials(
_ context.Context,
gitspaceConfig *types.GitspaceConfig,
) (*ResolvedCredentials, error) {
var resolvedDetails = &ResolvedDetails{}
resolvedDetails.Branch = gitspaceConfig.Branch
resolvedDetails.CloneURL = gitspaceConfig.CodeRepoURL
var resolvedCredentials = &ResolvedCredentials{
Branch: gitspaceConfig.Branch,
CloneURL: gitspaceConfig.CodeRepoURL,
}
repoURL, err := url.Parse(gitspaceConfig.CodeRepoURL)
if err != nil {
return nil, fmt.Errorf("failed to parse repository URL %s: %w", gitspaceConfig.CodeRepoURL, err)
}
repoName := strings.TrimSuffix(path.Base(repoURL.Path), ".git")
resolvedDetails.RepoName = repoName
return nil, err
resolvedCredentials.RepoName = repoName
return resolvedCredentials, err
}

4
app/gitspace/scm/scm.go
View File

@ -26,6 +26,7 @@ import (
"github.com/harness/gitness/git/command"
"github.com/harness/gitness/types"
"github.com/harness/gitness/types/enum"
)
var (
@ -88,6 +89,9 @@ func (s scm) GetSCMRepoDetails(
gitspaceConfig *types.GitspaceConfig,
) (*ResolvedDetails, error) {
filePath := devcontainerDefaultPath
if gitspaceConfig.CodeRepoType == "" {
gitspaceConfig.CodeRepoType = enum.CodeRepoTypeUnknown
}
scmProvider, err := s.scmProviderFactory.GetSCMProvider(gitspaceConfig.CodeRepoType)
if err != nil {
return nil, fmt.Errorf("failed to resolve scm provider: %w", err)