github/drone
5
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-21 11:29:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix issue with consecutive adds

Browse Source
This commit is contained in:
Vardan Bansal 2023-09-19 17:12:02 -07:00
parent 9bb1185331
commit a0edaeaec6
1 changed files with 25 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
web/src/pages/AddUpdatePipeline/AddUpdatePipeline.tsx
View File

@ -1,4 +1,4 @@
import React, { useCallback, useEffect, useMemo, useState } from 'react' import React, { useCallback, useEffect, useMemo, useRef, useState } from 'react'
import { useGet, useMutate } from 'restful-react' import { useGet, useMutate } from 'restful-react'
import { useParams } from 'react-router-dom' import { useParams } from 'react-router-dom'
import { get, isEmpty, isUndefined, set } from 'lodash-es' import { get, isEmpty, isUndefined, set } from 'lodash-es'
@ -88,6 +88,7 @@ const AddUpdatePipeline = (): JSX.Element => {
const [isExistingPipeline, setIsExistingPipeline] = useState<boolean>(false) const [isExistingPipeline, setIsExistingPipeline] = useState<boolean>(false)
const [isDirty, setIsDirty] = useState<boolean>(false) const [isDirty, setIsDirty] = useState<boolean>(false)
const [generatingPipeline, setGeneratingPipeline] = useState<boolean>(false) const [generatingPipeline, setGeneratingPipeline] = useState<boolean>(false)
const pipelineAsYAMLRef = useRef<string>('')
const pipelineSaveOption: PipelineSaveAndRunOption = { const pipelineSaveOption: PipelineSaveAndRunOption = {
title: getString('save'), title: getString('save'),
@ -227,20 +228,29 @@ const AddUpdatePipeline = (): JSX.Element => {
return existingPipeline return existingPipeline
} }
const handlePluginAddUpdateIntoYAML = useCallback( const handlePluginAddUpdateToPipeline = useCallback(
(_isUpdate: boolean, pluginFormData: Record<string, any>): void => { ({
pluginFormData,
existingYAML
}: {
isUpdate: boolean
pluginFormData: Record<string, any>
existingYAML: string
}): void => {
try { try {
const pipelineAsObj = parse(pipelineAsYAML) const pipelineAsObj = parse(existingYAML)
const updatedPipelineAsObj = updatePipelineWithPluginData(pipelineAsObj, pluginFormData) const updatedPipelineAsObj = updatePipelineWithPluginData(pipelineAsObj, pluginFormData)
if (Object.keys(updatedPipelineAsObj).length > 0) { if (Object.keys(updatedPipelineAsObj).length > 0) {
// avoid setting to empty pipeline in case pipeline update with plugin data fails // avoid setting to empty pipeline in case pipeline update with plugin data fails
setPipelineAsYaml(stringify(updatedPipelineAsObj)) const updatedPipelineAsYAML = stringify(updatedPipelineAsObj)
setPipelineAsYaml(updatedPipelineAsYAML)
pipelineAsYAMLRef.current = updatedPipelineAsYAML
} }
} catch (ex) { } catch (ex) {
// ignore exception // ignore exception
} }
}, },
[yamlVersion, isExistingPipeline, originalPipelineYAMLFileContent, pipelineAsYAML] []
) )
const handleGeneratePipeline = useCallback(async (): Promise<void> => { const handleGeneratePipeline = useCallback(async (): Promise<void> => {
@ -394,7 +404,15 @@ const AddUpdatePipeline = (): JSX.Element => {
</Container> </Container>
{yamlVersion === YamlVersion.V1 && ( {yamlVersion === YamlVersion.V1 && (
<Container className={css.pluginsContainer}> <Container className={css.pluginsContainer}>
<PluginsPanel onPluginAddUpdate={handlePluginAddUpdateIntoYAML} /> <PluginsPanel
onPluginAddUpdate={(isUpdate: boolean, pluginFormData: Record<string, any>) =>
handlePluginAddUpdateToPipeline({
isUpdate,
pluginFormData,
existingYAML: pipelineAsYAMLRef.current || pipelineAsYAML
})
}
/>
</Container> </Container>
)} )}
</Layout.Horizontal> </Layout.Horizontal>