github/drone
5
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-11 22:50:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

CODE-548: Update search to prID

Browse Source
This commit is contained in:
Akhilesh Pandey 2023-06-23 00:47:19 +05:30
parent 699156d56d
commit 9ebc5c1bea
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
internal/api/controller/pullreq/reviewer_delete.go
View File

@ -14,13 +14,16 @@ import (
// ReviewerDelete deletes reviewer from the reviewerlist for the given PR. // ReviewerDelete deletes reviewer from the reviewerlist for the given PR.
func (c *Controller) ReviewerDelete(ctx context.Context, session *auth.Session, func (c *Controller) ReviewerDelete(ctx context.Context, session *auth.Session,
repoRef string, prID, reviewerID int64) error { repoRef string, prNum, reviewerID int64) error {
_, err := c.getRepoCheckAccess(ctx, session, repoRef, enum.PermissionRepoEdit)
repo, err := c.getRepoCheckAccess(ctx, session, repoRef, enum.PermissionRepoEdit)
if err != nil { if err != nil {
return fmt.Errorf("failed to acquire access to repo: %w", err) return fmt.Errorf("failed to acquire access to repo: %w", err)
} }
err = c.reviewerStore.Delete(ctx, prID, reviewerID) pr, err := c.pullreqStore.FindByNumber(ctx, repo.ID, prNum)
err = c.reviewerStore.Delete(ctx, pr.ID, reviewerID)
if err != nil { if err != nil {
return fmt.Errorf("failed to delete reviewer: %w", err) return fmt.Errorf("failed to delete reviewer: %w", err)
} }

4
internal/api/handler/pullreq/reviewer_delete.go
View File

@ -24,7 +24,7 @@ func HandleReviewerDelete(pullreqCtrl *pullreq.Controller) http.HandlerFunc {
return return
} }
prID, err := request.GetPullReqNumberFromPath(r) prNum, err := request.GetPullReqNumberFromPath(r)
if err != nil { if err != nil {
render.TranslatedUserError(w, err) render.TranslatedUserError(w, err)
return return
@ -36,7 +36,7 @@ func HandleReviewerDelete(pullreqCtrl *pullreq.Controller) http.HandlerFunc {
return return
} }
err = pullreqCtrl.ReviewerDelete(ctx, session, repoRef, prID, reviewerID) err = pullreqCtrl.ReviewerDelete(ctx, session, repoRef, prNum, reviewerID)
if err != nil { if err != nil {
render.TranslatedUserError(w, err) render.TranslatedUserError(w, err)
return return