From 83aa52c65e21186aa2c55cb3db5aaf1f57a77184 Mon Sep 17 00:00:00 2001
From: Calvin Lee <calvin.lee@harness.io>
Date: Fri, 19 Apr 2024 05:08:19 +0000
Subject: [PATCH] fix: [code-1668]: hide commit selector on commit page (#1144)

---
 web/src/components/Changes/Changes.tsx         | 18 ++++++++++--------
 web/src/pages/Compare/Compare.tsx              |  1 +
 .../RepositoryCommit/RepositoryCommit.tsx      |  1 +
 3 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/web/src/components/Changes/Changes.tsx b/web/src/components/Changes/Changes.tsx
index b492cd0ea..88422e25a 100644
--- a/web/src/components/Changes/Changes.tsx
+++ b/web/src/components/Changes/Changes.tsx
@@ -83,6 +83,7 @@ interface ChangesProps extends Pick<GitInfoProps, 'repoMetadata'> {
   refetchActivities?: UseGetPullRequestInfoResult['refetchActivities']
   refetchCommits?: UseGetPullRequestInfoResult['refetchCommits']
   setPullReqChangesCount?: React.Dispatch<React.SetStateAction<number>>
+  showCommitsDropdown?: boolean
 }
 
 const ChangesInternal: React.FC<ChangesProps> = ({
@@ -100,7 +101,8 @@ const ChangesInternal: React.FC<ChangesProps> = ({
   scrollElement,
   refetchActivities,
   refetchCommits,
-  setPullReqChangesCount
+  setPullReqChangesCount,
+  showCommitsDropdown = true
 }) => {
   const { getString } = useStrings()
   const [viewStyle, setViewStyle] = useUserPreference(UserPreference.DIFF_VIEW_STYLE, ViewStyle.SIDE_BY_SIDE)
@@ -428,7 +430,6 @@ const ChangesInternal: React.FC<ChangesProps> = ({
   }, [diffs, setPullReqChangesCount])
 
   useShowRequestError(errorFileViews, 0)
-
   return (
     <Container className={cx(css.container, className)} {...(!!loadingRawDiff || !!error ? { flex: true } : {})}>
       <LoadingSpinner visible={loading} withBorder={true} />
@@ -439,12 +440,13 @@ const ChangesInternal: React.FC<ChangesProps> = ({
         <Container className={css.header} ref={headerRef}>
           <Layout.Horizontal>
             <Container flex={{ alignItems: 'center' }} style={{ visibility: diffs ? 'visible' : 'hidden' }}>
-              <CommitRangeDropdown
-                allCommits={pullReqCommits?.commits || []}
-                selectedCommits={commitRange}
-                setSelectedCommits={setCommitRange}
-              />
-
+              {showCommitsDropdown && (
+                <CommitRangeDropdown
+                  allCommits={pullReqCommits?.commits || []}
+                  selectedCommits={commitRange}
+                  setSelectedCommits={setCommitRange}
+                />
+              )}
               {/* Files Changed stats */}
               <Text flex className={css.diffStatsLabel}>
                 <StringSubstitute
diff --git a/web/src/pages/Compare/Compare.tsx b/web/src/pages/Compare/Compare.tsx
index f96ad0bce..77fc4adc3 100644
--- a/web/src/pages/Compare/Compare.tsx
+++ b/web/src/pages/Compare/Compare.tsx
@@ -414,6 +414,7 @@ export default function Compare() {
                   panel: (
                     <TabContentWrapper loading={loading} error={error} onRetry={noop} className={css.changesContainer}>
                       <Changes
+                        showCommitsDropdown={false}
                         readOnly={true}
                         repoMetadata={repoMetadata}
                         targetRef={targetGitRef}
diff --git a/web/src/pages/RepositoryCommit/RepositoryCommit.tsx b/web/src/pages/RepositoryCommit/RepositoryCommit.tsx
index a24a9d5e3..0e01947f7 100644
--- a/web/src/pages/RepositoryCommit/RepositoryCommit.tsx
+++ b/web/src/pages/RepositoryCommit/RepositoryCommit.tsx
@@ -53,6 +53,7 @@ export default function RepositoryCommits() {
       return (
         <Container className={css.changesContainer}>
           <Changes
+            showCommitsDropdown={false}
             readOnly={true}
             repoMetadata={repoMetadata}
             commitSHA={commitRef}