github/drone
5
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-19 18:39:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

Added missing context in some of the log calls (#250)

Browse Source
This commit is contained in:
Marko Gaćeša 2023-01-25 14:06:48 +01:00 committed by GitHub
parent fe3d6d5990
commit 825336d0e4
7 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/api/controller/pullreq/merge.go
View File

@ -131,7 +131,7 @@ func (c *Controller) Merge(
err = c.writeActivity(ctx, pr, activity) err = c.writeActivity(ctx, pr, activity)
if err != nil { if err != nil {
log.Err(err).Msg("failed to write pull req activity") log.Ctx(ctx).Err(err).Msg("failed to write pull req activity")
} }
c.eventReporter.Merged(ctx, &pullreqevents.MergedPayload{ c.eventReporter.Merged(ctx, &pullreqevents.MergedPayload{

2
internal/api/controller/pullreq/pr_state.go
View File

@ -124,7 +124,7 @@ func (c *Controller) State(ctx context.Context,
err = c.writeActivity(ctx, pr, getStateActivity(session, pr, in)) err = c.writeActivity(ctx, pr, getStateActivity(session, pr, in))
if err != nil { if err != nil {
// non-critical error // non-critical error
log.Err(err).Msg("failed to write pull req activity") log.Ctx(ctx).Err(err).Msg("failed to write pull req activity")
} }
c.eventReporter.StateChange(ctx, event) c.eventReporter.StateChange(ctx, event)

2
internal/api/controller/pullreq/pr_update.go
View File

@ -102,7 +102,7 @@ func (c *Controller) Update(ctx context.Context,
err = c.writeActivity(ctx, pr, activity) err = c.writeActivity(ctx, pr, activity)
if err != nil { if err != nil {
// non-critical error // non-critical error
log.Err(err).Msg("failed to write pull req activity") log.Ctx(ctx).Err(err).Msg("failed to write pull req activity")
} }
} }

2
internal/api/controller/pullreq/review_submit.go
View File

@ -113,7 +113,7 @@ func (c *Controller) ReviewSubmit(
err = c.writeActivity(ctx, pr, act) err = c.writeActivity(ctx, pr, act)
if err != nil { if err != nil {
// non-critical error // non-critical error
log.Err(err).Msg("failed to generate pull request activity entry for submitting review") log.Ctx(ctx).Err(err).Msg("failed to generate pull request activity entry for submitting review")
} }
return review, err return review, err

4
internal/store/database/pullreq.go
View File

@ -489,7 +489,7 @@ func (s *PullReqStore) mapPullReq(ctx context.Context, pr *pullReq) *types.PullR
author, err = s.pCache.Get(ctx, pr.CreatedBy) author, err = s.pCache.Get(ctx, pr.CreatedBy)
if err != nil { if err != nil {
log.Err(err).Msg("failed to load PR author") log.Ctx(ctx).Err(err).Msg("failed to load PR author")
} }
if author != nil { if author != nil {
m.Author = *author m.Author = *author
@ -498,7 +498,7 @@ func (s *PullReqStore) mapPullReq(ctx context.Context, pr *pullReq) *types.PullR
if pr.MergedBy.Valid { if pr.MergedBy.Valid {
merger, err = s.pCache.Get(ctx, pr.MergedBy.Int64) merger, err = s.pCache.Get(ctx, pr.MergedBy.Int64)
if err != nil { if err != nil {
log.Err(err).Msg("failed to load PR merger") log.Ctx(ctx).Err(err).Msg("failed to load PR merger")
} }
m.Merger = merger m.Merger = merger
} }

4
internal/store/database/pullreq_activity.go
View File

@ -411,7 +411,7 @@ func (s *PullReqActivityStore) mapPullReqActivity(ctx context.Context, act *pull
author, err = s.pCache.Get(ctx, act.CreatedBy) author, err = s.pCache.Get(ctx, act.CreatedBy)
if err != nil { if err != nil {
log.Err(err).Msg("failed to load PR activity author") log.Ctx(ctx).Err(err).Msg("failed to load PR activity author")
} }
if author != nil { if author != nil {
m.Author = *author m.Author = *author
@ -420,7 +420,7 @@ func (s *PullReqActivityStore) mapPullReqActivity(ctx context.Context, act *pull
if act.ResolvedBy.Valid { if act.ResolvedBy.Valid {
resolver, err = s.pCache.Get(ctx, act.ResolvedBy.Int64) resolver, err = s.pCache.Get(ctx, act.ResolvedBy.Int64)
if err != nil { if err != nil {
log.Err(err).Msg("failed to load PR activity resolver") log.Ctx(ctx).Err(err).Msg("failed to load PR activity resolver")
} }
m.Resolver = resolver m.Resolver = resolver
} }

4
internal/store/database/pullreq_reviewers.go
View File

@ -241,7 +241,7 @@ func (s *PullReqReviewerStore) mapPullReqReviewer(ctx context.Context, v *pullRe
addedBy, err := s.pCache.Get(ctx, v.CreatedBy) addedBy, err := s.pCache.Get(ctx, v.CreatedBy)
if err != nil { if err != nil {
log.Err(err).Msg("failed to load PR reviewer addedBy") log.Ctx(ctx).Err(err).Msg("failed to load PR reviewer addedBy")
} }
if addedBy != nil { if addedBy != nil {
m.AddedBy = *addedBy m.AddedBy = *addedBy
@ -249,7 +249,7 @@ func (s *PullReqReviewerStore) mapPullReqReviewer(ctx context.Context, v *pullRe
reviewer, err := s.pCache.Get(ctx, v.PrincipalID) reviewer, err := s.pCache.Get(ctx, v.PrincipalID)
if err != nil { if err != nil {
log.Err(err).Msg("failed to load PR reviewer principal") log.Ctx(ctx).Err(err).Msg("failed to load PR reviewer principal")
} }
if reviewer != nil { if reviewer != nil {
m.Reviewer = *reviewer m.Reviewer = *reviewer