github/drone
5
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-21 03:20:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix infinite setState causing app is broken when swiching space <> no space

Browse Source
This commit is contained in:
“tan-nhu” 2023-09-20 04:11:29 -07:00
parent 5eff33c75f
commit 80c74fa36a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/components/SpaceSelector/SpaceSelector.tsx
View File

@ -72,7 +72,7 @@ export const SpaceSelector: React.FC<SpaceSelectorProps> = ({ onSelect }) => {
useEffect(() => { useEffect(() => {
if (space && !selectedSpace && data) { if (space && !selectedSpace && data) {
selectSpace(data, false) selectSpace(data, false)
} else if (!space && selectSpace && data) { } else if (!space && selectSpace && data && selectedSpace?.id !== -1) {
selectSpace( selectSpace(
{ {
created: 0, created: 0,
@ -88,7 +88,7 @@ export const SpaceSelector: React.FC<SpaceSelectorProps> = ({ onSelect }) => {
false false
) )
} }
}, [space, selectedSpace, data, onSelect, selectSpace]) }, [space, selectedSpace, data, onSelect, selectSpace, getString])
useEffect(() => { useEffect(() => {
if (response?.status === 403) { if (response?.status === 403) {