From 71eab8e042a3d561913e94fdce0c1dd261fb0f7f Mon Sep 17 00:00:00 2001
From: Akhilesh Pandey <1akhil.pandey@gmail.com>
Date: Wed, 26 Jul 2023 09:38:59 +0530
Subject: [PATCH] [CODE-621]: Move registration func out of controller struct

---
 internal/api/controller/system/controller.go | 24 +++++++++-----------
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/internal/api/controller/system/controller.go b/internal/api/controller/system/controller.go
index 1a7018066..1f8696305 100644
--- a/internal/api/controller/system/controller.go
+++ b/internal/api/controller/system/controller.go
@@ -11,25 +11,23 @@ import (
 	"github.com/harness/gitness/types"
 )
 
-type registrationCheck func(ctx context.Context) (bool, error)
-
 type Controller struct {
-	principalStore            store.PrincipalStore
-	config                    *types.Config
-	IsUserRegistrationAllowed registrationCheck
+	principalStore store.PrincipalStore
+	config         *types.Config
 }
 
 func NewController(principalStore store.PrincipalStore, config *types.Config) *Controller {
 	return &Controller{
 		principalStore: principalStore,
 		config:         config,
-		IsUserRegistrationAllowed: func(ctx context.Context) (bool, error) {
-			usrCount, err := principalStore.CountUsers(ctx)
-			if err != nil {
-				return false, err
-			}
-
-			return usrCount == 0 || config.AllowSignUp, nil
-		},
 	}
 }
+
+func (c *Controller) IsUserRegistrationAllowed(ctx context.Context) (bool, error) {
+	usrCount, err := c.principalStore.CountUsers(ctx)
+	if err != nil {
+		return false, err
+	}
+
+	return usrCount == 0 || c.config.AllowSignUp, nil
+}