github/drone
5
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-09 01:42:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

[MISC] Fix Admin Status Removal (#637)

Browse Source
This commit is contained in:
Johannes Batzill 2023-09-29 21:11:29 +00:00 committed by Harness
parent 9bb2ca1f5e
commit 6ec908b76d
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/api/controller/user/update_admin.go
View File

@ -44,18 +44,17 @@ func (c *Controller) UpdateAdmin(ctx context.Context, session *auth.Session,
}
// Fail if the user being updated is the only admin in DB.
if !request.Admin && user.Admin {
if user.Admin && !request.Admin {
admUsrCount, err := c.principalStore.CountUsers(ctx, &types.UserFilter{Admin: true})
if err != nil {
return nil, fmt.Errorf("failed to check admin user count: %w", err)
}
if admUsrCount == 1 {
if admUsrCount <= 1 {
return nil, usererror.BadRequest("system requires at least one admin user")
}
return user, nil
}
user.Admin = request.Admin
user.Updated = time.Now().UnixMilli()