From 4e9ce9d81a7246e794b8d847e3bd6a174ca75b3c Mon Sep 17 00:00:00 2001
From: Shivanand Sonnad <shivanand.sonnad@harness.io>
Date: Tue, 8 Apr 2025 11:17:53 +0000
Subject: [PATCH] feat: [AH-680]: fix not showing scan data on global artifact
 list page (#3646)

* feat: [AH-680]: resolve PR comments
* feat: [AH-680]: fix not showing scan data on global artifact list page
---
 web/package.json                              |   2 +-
 .../ArtifactListTableCell.tsx                 | 108 +++++++++---------
 web/yarn.lock                                 |   8 +-
 3 files changed, 60 insertions(+), 58 deletions(-)

diff --git a/web/package.json b/web/package.json
index fcde25251..e819e0bb0 100644
--- a/web/package.json
+++ b/web/package.json
@@ -51,7 +51,7 @@
     "@codemirror/view": "^6.9.6",
     "@harnessio/design-system": "^2.1.1",
     "@harnessio/icons": "^2.1.9",
-    "@harnessio/react-har-service-client": "^0.16.0",
+    "@harnessio/react-har-service-client": "^0.17.0",
     "@harnessio/react-ng-manager-client": "^1.40.0",
     "@harnessio/react-ssca-manager-client": "^0.65.0",
     "@harnessio/uicore": "^4.1.2",
diff --git a/web/src/ar/pages/artifact-list/components/ArtifactListTable/ArtifactListTableCell.tsx b/web/src/ar/pages/artifact-list/components/ArtifactListTable/ArtifactListTableCell.tsx
index 6f7e8fa22..78c711bfe 100644
--- a/web/src/ar/pages/artifact-list/components/ArtifactListTable/ArtifactListTableCell.tsx
+++ b/web/src/ar/pages/artifact-list/components/ArtifactListTable/ArtifactListTableCell.tsx
@@ -14,16 +14,17 @@
  * limitations under the License.
  */
 
-import React, { useState } from 'react'
+import React from 'react'
+import QueryString from 'qs'
 import { defaultTo } from 'lodash-es'
-import { Link, useHistory } from 'react-router-dom'
-import { Menu, Position } from '@blueprintjs/core'
+import { Link } from 'react-router-dom'
+import { Position } from '@blueprintjs/core'
 import { Color, FontVariation } from '@harnessio/design-system'
 import { Button, ButtonVariation, Layout, Text } from '@harnessio/uicore'
 import type { Cell, CellValue, ColumnInstance, Renderer, Row, TableInstance } from 'react-table'
 import type { ArtifactMetadata, StoDigestMetadata } from '@harnessio/react-har-service-client'
 
-import { useParentComponents, useRoutes } from '@ar/hooks'
+import { useRoutes } from '@ar/hooks'
 import TableCells from '@ar/components/TableCells/TableCells'
 import { PageType, RepositoryPackageType } from '@ar/common/types'
 import LabelsPopover from '@ar/components/LabelsPopover/LabelsPopover'
@@ -126,65 +127,66 @@ export const ArtifactListPullCommandCell: CellType = ({ value, row }) => {
   }
 }
 
+interface ScannedDigestListProps {
+  list: StoDigestMetadata[]
+  metadata: ArtifactMetadata
+}
+
+const ScannedDigestList = (props: ScannedDigestListProps) => {
+  const { list, metadata } = props
+  const routes = useRoutes()
+  return (
+    <Layout.Vertical width={450}>
+      {list.map(each => (
+        <Layout.Horizontal
+          padding="small"
+          spacing="medium"
+          flex={{ alignItems: 'center', justifyContent: 'space-between' }}
+          key={each.digest}>
+          <TableCells.LinkCell
+            linkTo={
+              routes.toARVersionDetailsTab({
+                repositoryIdentifier: metadata.registryIdentifier,
+                artifactIdentifier: metadata.name,
+                versionIdentifier: metadata.version,
+                versionTab: VersionDetailsTab.OVERVIEW
+              }) + `?${QueryString.stringify({ digest: each.digest }, { skipNulls: true })}`
+            }
+            label={getShortDigest(each.digest || '')}
+          />
+          <TableCells.TextCell value={each.osArch} />
+          <TableCells.VulnerabilityCell
+            critical={each.stoDetails?.critical}
+            high={each.stoDetails?.high}
+            low={each.stoDetails?.low}
+            medium={each.stoDetails?.medium}
+          />
+        </Layout.Horizontal>
+      ))}
+    </Layout.Vertical>
+  )
+}
+
 export const ArtifactListVulnerabilitiesCell: CellType = ({ row }) => {
   const { original } = row
-  const { stoMetadata, registryIdentifier, name, version } = original
+  const { stoMetadata } = original
   const { scannedCount, totalCount, digestMetadata } = stoMetadata || {}
-  const [isOptionsOpen, setIsOptionsOpen] = useState(false)
   const { getString } = useStrings()
-  const { RbacMenuItem } = useParentComponents()
-  const routes = useRoutes()
-  const history = useHistory()
-
-  const handleRenderDigestMenuItem = (digest: StoDigestMetadata) => {
-    return (
-      <RbacMenuItem
-        text={getString('artifactList.table.actions.VulnerabilityStatus.digestMenuItemText', {
-          archName: digest.osArch,
-          digest: getShortDigest(digest.digest || '')
-        })}
-        onClick={() => {
-          const url = routes.toARVersionDetailsTab({
-            repositoryIdentifier: registryIdentifier,
-            artifactIdentifier: name,
-            versionIdentifier: version as string,
-            versionTab: VersionDetailsTab.SECURITY_TESTS,
-            pipelineIdentifier: digest.stoPipelineId,
-            executionIdentifier: digest.stoExecutionId
-          })
-          history.push(`${url}?digest=${digest.digest}`)
-        }}
-      />
-    )
-  }
 
   if (!scannedCount) {
     return <Text>{getString('artifactList.table.actions.VulnerabilityStatus.nonScanned')}</Text>
   }
 
   return (
-    <Button
-      className={css.cellBtn}
-      tooltip={
-        <Menu
-          className={css.optionsMenu}
-          onClick={e => {
-            e.stopPropagation()
-            setIsOptionsOpen(false)
-          }}>
-          {digestMetadata?.map(handleRenderDigestMenuItem)}
-        </Menu>
-      }
-      tooltipProps={{
-        interactionKind: 'click',
-        onInteraction: nextOpenState => {
-          setIsOptionsOpen(nextOpenState)
-        },
-        isOpen: isOptionsOpen,
-        position: Position.BOTTOM
-      }}
-      variation={ButtonVariation.LINK}>
-      <Text font={{ variation: FontVariation.BODY }} color={Color.PRIMARY_7}>
+    <Button className={css.cellBtn} variation={ButtonVariation.LINK}>
+      <Text
+        font={{ variation: FontVariation.BODY }}
+        color={Color.PRIMARY_7}
+        tooltipProps={{
+          interactionKind: 'click',
+          position: Position.BOTTOM
+        }}
+        tooltip={<ScannedDigestList list={digestMetadata || []} metadata={original} />}>
         {getString('artifactList.table.actions.VulnerabilityStatus.partiallyScanned', {
           total: defaultTo(totalCount, 0),
           scanned: defaultTo(scannedCount, 0)
diff --git a/web/yarn.lock b/web/yarn.lock
index 5c56c56b5..4fc5826c5 100644
--- a/web/yarn.lock
+++ b/web/yarn.lock
@@ -1945,10 +1945,10 @@
     yargs "^17.6.2"
     zod "^3.19.1"
 
-"@harnessio/react-har-service-client@^0.16.0":
-  version "0.16.0"
-  resolved "https://registry.yarnpkg.com/@harnessio/react-har-service-client/-/react-har-service-client-0.16.0.tgz#5fca5fa25b003cb87f21fe03132c4888aa6ea6bb"
-  integrity sha512-bf3lA5Yh3tpbn6kxeDrN+7ERp/btkZERYjO8oNe+SsM7tQttFRZyyAk1nFYcMc6oUOATLHN/wwYdsXuOLhcjiw==
+"@harnessio/react-har-service-client@^0.17.0":
+  version "0.17.0"
+  resolved "https://registry.yarnpkg.com/@harnessio/react-har-service-client/-/react-har-service-client-0.17.0.tgz#0d292fd06a706469a850001af052055846c4e4a2"
+  integrity sha512-NhSdpuFydxXaaxZJrjXuUfz61pXsWGy0qDqgoel6PRu6VuUHMxzl1n/8jhJh4gqCJAj7RHxbq2292NfhKlRcUA==
   dependencies:
     "@harnessio/oats-cli" "^3.0.0"