github/drone
5
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-19 02:20:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

[SSE] close pubsub subscriber on sse completion (#769)

Browse Source
This commit is contained in:
Johannes Batzill 2023-11-06 18:16:24 +00:00 committed by Harness
parent e731c0fdff
commit 4e0444bba8
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/sse/sse.go
View File

@ -96,11 +96,11 @@ func (e *pubsubStreamer) Stream(
namespaceOption := pubsub.WithChannelNamespace(e.namespace) namespaceOption := pubsub.WithChannelNamespace(e.namespace)
topic := getSpaceTopic(spaceID) topic := getSpaceTopic(spaceID)
consumer := e.pubsub.Subscribe(ctx, topic, g, namespaceOption) consumer := e.pubsub.Subscribe(ctx, topic, g, namespaceOption)
unsubscribeFN := func(ctx context.Context) error { cleanupFN := func(ctx context.Context) error {
return consumer.Unsubscribe(ctx, topic) return consumer.Close()
} }
return chEvent, chErr, unsubscribeFN return chEvent, chErr, cleanupFN
} }
// getSpaceTopic creates the namespace name which will be `spaces:<id>`. // getSpaceTopic creates the namespace name which will be `spaces:<id>`.