github/drone
5
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-07 04:21:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

Disallowing : in the path for a cached entry

Browse Source
This commit is contained in:
Don Olmstead 2015-08-07 16:18:11 -07:00 committed by Olmstead
parent 7189d1390e
commit 3fdee1b8e8
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/yaml/lint.go
View File

@ -110,6 +110,10 @@ func expectTrustedNotify(c *common.Config) error {
// in the workspace. // in the workspace.
func expectCacheInWorkspace(c *common.Config) error { func expectCacheInWorkspace(c *common.Config) error {
for _, step := range c.Build.Cache { for _, step := range c.Build.Cache {
if strings.Index(step, ":") != -1 {
return fmt.Errorf("Cache cannot contain : in the path")
}
cleaned := filepath.Clean(step) cleaned := filepath.Clean(step)
if strings.Index(cleaned, "../") != -1 { if strings.Index(cleaned, "../") != -1 {

9
pkg/yaml/lint_test.go
View File

@ -114,6 +114,15 @@ func Test_Linter(t *testing.T) {
} }
g.Assert(expectCacheInWorkspace(c) != nil).IsTrue() g.Assert(expectCacheInWorkspace(c) != nil).IsTrue()
}) })
g.It("Should fail when : is in the path", func() {
c := &common.Config{
Build: &common.Step{
Cache: []string{".git",".git:/../"},
},
}
g.Assert(expectCacheInWorkspace(c) != nil).IsTrue()
})
}) })
} }