github/drone
5
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-10 22:21:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Protection Rules] Load user from store in pre-receive hook (#747)

Browse Source
This commit is contained in:
Johannes Batzill 2023-10-31 04:25:12 +00:00 committed by Harness
parent b7e68971b0
commit 3418dd1127
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/api/controller/githook/pre_receive.go
View File

@ -67,9 +67,14 @@ func (c *Controller) PreReceive(
return output, nil
}
// TODO: Remove the dummy session and use the real session, once that has been done and the session has a value.
// TODO: use store.PrincipalInfoCache once we abstracted principals.
principal, err := c.principalStore.Find(ctx, principalID)
if err != nil {
return nil, fmt.Errorf("failed to find inner principal with id %d: %w", principalID, err)
}
dummySession := &auth.Session{
Principal: types.Principal{ID: principalID, Admin: false}, // TODO: In the dummySession "Admin" is always false
Principal: *principal,
Metadata: nil,
}