From 2f83725e121dda8604edf6e4692600d56d2511dd Mon Sep 17 00:00:00 2001 From: Vikyath Harekal Date: Tue, 10 Dec 2024 15:21:09 +0000 Subject: [PATCH] feat: [CDE-549]: print buffer logs before exiting (#3145) * feat: [CDE-549]: print buffer logs before exiting * feat: [CDE-549]: print buffer logs before exiting --- .../container/devcontainer_container_utils.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/app/gitspace/orchestrator/container/devcontainer_container_utils.go b/app/gitspace/orchestrator/container/devcontainer_container_utils.go index 54aa334af..ec98cfe18 100644 --- a/app/gitspace/orchestrator/container/devcontainer_container_utils.go +++ b/app/gitspace/orchestrator/container/devcontainer_container_utils.go @@ -408,10 +408,7 @@ func CopyImage( cmd.Stderr = &errBuf gitspaceLogger.Info("Executing image copy command: " + cmd.String()) - err := cmd.Run() - if err != nil { - return logStreamWrapError(gitspaceLogger, "Error while pulling image using skopeo", err) - } + cmdErr := cmd.Run() // Log command output response, err := io.ReadAll(&outBuf) @@ -426,6 +423,10 @@ func CopyImage( } gitspaceLogger.Error("Image copy error output: "+string(errResponse), nil) + if cmdErr != nil { + return logStreamWrapError(gitspaceLogger, "Error while pulling image using skopeo", cmdErr) + } + gitspaceLogger.Info("Image copy completed successfully using skopeo") return nil }