From 1aa1123bd21fbae1be777d93cea19f4a4a72a23f Mon Sep 17 00:00:00 2001 From: Tan Nhu Date: Tue, 17 Jan 2023 14:59:56 -0800 Subject: [PATCH] Consolidate pagination for the whole codebase + Use SearchInputWithSpinner component (#222) * Remove center layout for empty repo info - hard to read * Consolidate pagination for the whole codebase * Use SearchInputWithSpinner component * Use SearchInputWithSpinner component --- .../PrevNextPagination/PrevNextPagination.tsx | 40 ------ .../ResourceListingPagination.module.scss} | 4 + ...esourceListingPagination.module.scss.d.ts} | 1 + .../ResourceListingPagination.tsx | 107 ++++++++++++++++ .../SearchInputWithSpinner.module.scss | 20 +++ .../SearchInputWithSpinner.module.scss.d.ts | 9 ++ .../SearchInputWithSpinner.tsx | 44 +++++++ web/src/framework/strings/stringTypes.ts | 1 + web/src/hooks/useGetPaginationInfo.ts | 11 -- web/src/hooks/usePageIndex.ts | 2 +- web/src/hooks/useShowRequestError.ts | 14 +++ web/src/i18n/strings.en.yaml | 1 + web/src/pages/Compare/Compare.tsx | 16 ++- .../PullRequestCommits/PullRequestCommits.tsx | 14 +-- web/src/pages/PullRequests/PullRequests.tsx | 45 ++++--- .../PullRequestsContentHeader.module.scss | 9 -- ...PullRequestsContentHeader.module.scss.d.ts | 1 - .../PullRequestsContentHeader.tsx | 17 +-- .../RepositoriesListing.module.scss | 8 +- .../RepositoriesListing.module.scss.d.ts | 2 +- .../RepositoriesListing.tsx | 45 ++----- .../FolderContent/Readme.tsx | 8 +- .../BranchesContentHeader.tsx | 18 +-- .../RepositoryBranchesContent.tsx | 27 ++--- .../RepositoryCommits.module.scss | 4 - .../RepositoryCommits.module.scss.d.ts | 1 - .../RepositoryCommits/RepositoryCommits.tsx | 25 ++-- web/src/pages/Webhooks/Webhooks.module.scss | 4 + .../pages/Webhooks/Webhooks.module.scss.d.ts | 1 + web/src/pages/Webhooks/Webhooks.tsx | 114 ++++++++++-------- .../WebhooksHeader/WebhooksHeader.module.scss | 11 +- .../WebhooksHeader.module.scss.d.ts | 1 + .../WebhooksHeader/WebhooksHeader.tsx | 19 ++- web/src/utils/GitUtils.ts | 2 +- 34 files changed, 397 insertions(+), 249 deletions(-) delete mode 100644 web/src/components/PrevNextPagination/PrevNextPagination.tsx rename web/src/components/{PrevNextPagination/PrevNextPagination.module.scss => ResourceListingPagination/ResourceListingPagination.module.scss} (95%) rename web/src/components/{PrevNextPagination/PrevNextPagination.module.scss.d.ts => ResourceListingPagination/ResourceListingPagination.module.scss.d.ts} (89%) create mode 100644 web/src/components/ResourceListingPagination/ResourceListingPagination.tsx create mode 100644 web/src/components/SearchInputWithSpinner/SearchInputWithSpinner.module.scss create mode 100644 web/src/components/SearchInputWithSpinner/SearchInputWithSpinner.module.scss.d.ts create mode 100644 web/src/components/SearchInputWithSpinner/SearchInputWithSpinner.tsx delete mode 100644 web/src/hooks/useGetPaginationInfo.ts create mode 100644 web/src/hooks/useShowRequestError.ts diff --git a/web/src/components/PrevNextPagination/PrevNextPagination.tsx b/web/src/components/PrevNextPagination/PrevNextPagination.tsx deleted file mode 100644 index af46f140f..000000000 --- a/web/src/components/PrevNextPagination/PrevNextPagination.tsx +++ /dev/null @@ -1,40 +0,0 @@ -import React from 'react' -import cx from 'classnames' -import { Button, ButtonSize, Container, Layout } from '@harness/uicore' -import { useStrings } from 'framework/strings' -import css from './PrevNextPagination.module.scss' - -interface PrevNextPaginationProps { - onPrev?: false | (() => void) - onNext?: false | (() => void) - skipLayout?: boolean -} - -export function PrevNextPagination({ onPrev, onNext, skipLayout }: PrevNextPaginationProps) { - const { getString } = useStrings() - - return ( - - -