From 98a984a003c4b25642a4c96a5acf41eee46a7942 Mon Sep 17 00:00:00 2001 From: Kevin Tsai Date: Wed, 12 Jul 2017 16:29:03 +0900 Subject: [PATCH] add test in secret validation --- model/secret_test.go | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/model/secret_test.go b/model/secret_test.go index 16e1e6594..02c7cb248 100644 --- a/model/secret_test.go +++ b/model/secret_test.go @@ -25,10 +25,26 @@ func TestSecret(t *testing.T) { secret := Secret{} g.Assert(secret.Match("pull_request")).IsTrue() }) - g.It("should pass validation") + g.It("should pass validation", func() { + secret := Secret{} + secret.Name = "secretname" + secret.Value = "secretvalue" + err := secret.Validate() + g.Assert(err).Equal(nil) + }) g.Describe("should fail validation", func() { - g.It("when no image") - g.It("when no event") + g.It("when no name", func() { + secret := Secret{} + secret.Value = "secretvalue" + err := secret.Validate() + g.Assert(err != nil).IsTrue() + }) + g.It("when no value", func() { + secret := Secret{} + secret.Name = "secretname" + err := secret.Validate() + g.Assert(err != nil).IsTrue() + }) }) }) }