From b7390ab2887980b4c3f33d6640a3c3f114c3d4f0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E6=80=80=E8=B0=B7?= <huaigu@qunhemail.com>
Date: Fri, 22 Jul 2022 16:47:28 +0800
Subject: [PATCH] optimize code

---
 .../mongodbreader/MongoDBReaderErrorCode.java       | 13 +++++++++++--
 .../plugin/reader/mongodbreader/util/MongoUtil.java |  9 +++++----
 2 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/mongodbreader/src/main/java/com/alibaba/datax/plugin/reader/mongodbreader/MongoDBReaderErrorCode.java b/mongodbreader/src/main/java/com/alibaba/datax/plugin/reader/mongodbreader/MongoDBReaderErrorCode.java
index 4b3780c2..46e50e22 100644
--- a/mongodbreader/src/main/java/com/alibaba/datax/plugin/reader/mongodbreader/MongoDBReaderErrorCode.java
+++ b/mongodbreader/src/main/java/com/alibaba/datax/plugin/reader/mongodbreader/MongoDBReaderErrorCode.java
@@ -7,15 +7,24 @@ import com.alibaba.datax.common.spi.ErrorCode;
  */
 public enum MongoDBReaderErrorCode implements ErrorCode {
 
+    /**
+     * 参数不合法
+     */
     ILLEGAL_VALUE("ILLEGAL_PARAMETER_VALUE","参数不合法"),
+    /**
+     * 不合法的Mongo地址
+     */
     ILLEGAL_ADDRESS("ILLEGAL_ADDRESS","不合法的Mongo地址"),
-    UNEXCEPT_EXCEPTION("UNEXCEPT_EXCEPTION","未知异常");
+    /**
+     * 未知异常
+     */
+    UNEXPECTED_EXCEPTION("UNEXPECTED_EXCEPTION","未知异常");
 
     private final String code;
 
     private final String description;
 
-    private MongoDBReaderErrorCode(String code,String description) {
+    MongoDBReaderErrorCode(String code,String description) {
         this.code = code;
         this.description = description;
     }
diff --git a/mongodbreader/src/main/java/com/alibaba/datax/plugin/reader/mongodbreader/util/MongoUtil.java b/mongodbreader/src/main/java/com/alibaba/datax/plugin/reader/mongodbreader/util/MongoUtil.java
index ae7a2dd3..95544078 100644
--- a/mongodbreader/src/main/java/com/alibaba/datax/plugin/reader/mongodbreader/util/MongoUtil.java
+++ b/mongodbreader/src/main/java/com/alibaba/datax/plugin/reader/mongodbreader/util/MongoUtil.java
@@ -3,6 +3,7 @@ package com.alibaba.datax.plugin.reader.mongodbreader.util;
 import java.net.UnknownHostException;
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.Collections;
 import java.util.List;
 
 import com.alibaba.datax.common.exception.DataXException;
@@ -33,7 +34,7 @@ public class MongoUtil {
         } catch (NumberFormatException e) {
             throw DataXException.asDataXException(MongoDBReaderErrorCode.ILLEGAL_VALUE,"不合法参数");
         } catch (Exception e) {
-            throw DataXException.asDataXException(MongoDBReaderErrorCode.UNEXCEPT_EXCEPTION,"未知异常");
+            throw DataXException.asDataXException(MongoDBReaderErrorCode.UNEXPECTED_EXCEPTION,"未知异常");
         }
     }
 
@@ -45,14 +46,14 @@ public class MongoUtil {
         }
         try {
             MongoCredential credential = MongoCredential.createCredential(userName, database, password.toCharArray());
-            return new MongoClient(parseServerAddress(addressList), Arrays.asList(credential));
+            return new MongoClient(parseServerAddress(addressList), Collections.singletonList(credential));
 
         } catch (UnknownHostException e) {
             throw DataXException.asDataXException(MongoDBReaderErrorCode.ILLEGAL_ADDRESS,"不合法的地址");
         } catch (NumberFormatException e) {
             throw DataXException.asDataXException(MongoDBReaderErrorCode.ILLEGAL_VALUE,"不合法参数");
         } catch (Exception e) {
-            throw DataXException.asDataXException(MongoDBReaderErrorCode.UNEXCEPT_EXCEPTION,"未知异常");
+            throw DataXException.asDataXException(MongoDBReaderErrorCode.UNEXPECTED_EXCEPTION,"未知异常");
         }
     }
     /**
@@ -79,7 +80,7 @@ public class MongoUtil {
         for(Object address : rawAddressList) {
             String[] tempAddress = ((String)address).split(":");
             try {
-                ServerAddress sa = new ServerAddress(tempAddress[0],Integer.valueOf(tempAddress[1]));
+                ServerAddress sa = new ServerAddress(tempAddress[0],Integer.parseInt(tempAddress[1]));
                 addressList.add(sa);
             } catch (Exception e) {
                 throw new UnknownHostException();